-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve newspaper creation #4924
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kitodo/src/main/java/org/kitodo/production/converter/ProcessDetailConverter.java
Outdated
Show resolved
Hide resolved
Kitodo/src/main/java/org/kitodo/production/converter/ProcessDetailConverter.java
Outdated
Show resolved
Hide resolved
Kitodo/src/main/java/org/kitodo/production/converter/ProcessDetailConverter.java
Outdated
Show resolved
Hide resolved
Kitodo/src/main/java/org/kitodo/production/converter/ProcessDetailConverter.java
Outdated
Show resolved
Hide resolved
Kitodo/src/main/java/org/kitodo/production/converter/ProcessDetailConverter.java
Outdated
Show resolved
Hide resolved
Kitodo/src/main/java/org/kitodo/production/model/bibliography/course/IndividualIssue.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/kitodo/production/model/bibliography/course/metadata/CountableMetadata.java
Outdated
Show resolved
Hide resolved
@andre-hohmann : Can you please test this issue #4900 again to see if it has been fixed in meantime |
✅
✅ @andre-hohmann I added these changes to the current preview system. Could you check whether they fix #3974 in your opinion or not? |
@IkramMaalej : #4900 has not been fixed. It is still possible to create newspaper processes with existing process titles: |
@solth : #3974 is not fixed. It is necessary to scroll down to the new metadata element and then back up to the button "Metadatum hinzufügen" to create the next metadata element. Is is not possible to show the metadata in a list as in the regular creation of processes? The button "Als letzte Ausgabe festlegen" could be added to each metadata field. It would then not be necessary to add all needed metadata elements manually and to chose the fields and values, ... Sorry, if i am only complaining, ... It is however great, that the standard-values of the ruleset are implemented. |
I am not sure, but I thought it's possible to add metadata to individual issues, hence the need for multiple buttons.
|
That's right. The metadata is added to all issues between the two specified dates and issues (e.g. "2010-01-04, 2-Spätausgabe" and "2010-03-04, 2-Spätausgabe"). If this specified beginning is for example the second issue on this date, the metadata will not be added to the first issue "Frühausgabe" (being outside the specified range). |
@solth , @oliver-stoehr : I do not really understand the current state. When i use the button "Metadatum hinzufügen" as shown in the gif above, the element is added to both issues. My question is now: Is my observation incorrect? Is it not possible to move the button "Metadatum hinzufügen" to another position? |
@solth : Here two general hints:
|
ab3bd8e
to
c88ef1f
Compare
@IkramMaalej: Thanks a lot for the improvements! Summary
Review
|
Part of #4322
Fixes #3305
Fixes #3593
Fixes #3864
Fixes #3974
Fixes #4761
Fixes #4759
Fixes #4900